docs(lsp): explain why language_id should be preferred#19976
Merged
graphite-app[bot] merged 1 commit intomainfrom Mar 3, 2026
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-editor
Sysix
changed the title
language_id should be prefferedlanguage_id should be preferred
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the language server’s Tool trait documentation to clarify how formatters should determine the language for a document, emphasizing use of the LSP-provided language_id.
Changes:
- Document that
language_idshould be preferred over file extensions when selecting formatting/parsing behavior. - Note a fallback to file extension/heuristics when the language cannot be determined from
language_id. - Call out config-like files (e.g.
.oxlintrc.json) that may require JSON-with-comments handling.
8 tasks
Sysix
force-pushed
the
03-03-docs_lsp_explain_why_language_id_should_be_preffered
branch
2 times, most recently
from
14fdd63 to
5a883c3
Compare
Sysix
force-pushed
the
03-03-docs_lsp_explain_why_language_id_should_be_preffered
branch
2 times, most recently
from
a8d1845 to
03f4e2c
Compare
Sysix
force-pushed
the
03-03-docs_lsp_explain_why_language_id_should_be_preffered
branch
from
03f4e2c to
2be509c
Compare
Member
Author
Merge activity
|
> ## Pull request overview > > Updates the language server’s `LanguageId` trait documentation to clarify how formatters should determine the language for a document, emphasizing use of the LSP-provided `language_id`.
graphite-app
bot
force-pushed
the
03-03-docs_lsp_explain_why_language_id_should_be_preffered
branch
from
2be509c to
6095cde
Compare
graphite-app
bot
deleted the
03-03-docs_lsp_explain_why_language_id_should_be_preffered
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.